Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate circles after packing siblings. #39

Closed
mbostock opened this issue May 3, 2016 · 0 comments
Closed

Translate circles after packing siblings. #39

mbostock opened this issue May 3, 2016 · 0 comments
Assignees
@mbostock

Comments

@mbostock
Copy link
Member

mbostock commented May 3, 2016

The change in 0.2.1 makes d3.packSiblings somewhat unpredictable, since the weighted centroid can drift an arbitrary distance away from the origin. It’d be better to translate everything back to the origin when we’re done. Although note that this step is not necessary for d3.pack, since that will compute the enclosing circle and translate to its center. We should probably have a private method for packing siblings that is separate from the public one.
@mbostock mbostock self-assigned this May 3, 2016
@mbostock mbostock changed the title Translate circles to the centroid after packing siblings. Translate circles after packing siblings. May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock