Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sending any useful changes upstream #37

Closed
danomatika opened this issue Oct 19, 2020 · 3 comments
Closed

Consider sending any useful changes upstream #37

danomatika opened this issue Oct 19, 2020 · 3 comments

Comments

@danomatika
Copy link

I figure creating a single issue here is faster.

Howdy, nice project.

I see you needed to fork some of my addons: ofxGLEditor, ofxLua, ofxMidi. If you have the time, please consider porting required changes upstream via PRs etc and we can work towards having the project build without needing forks.

@d3cod3
Copy link
Owner

d3cod3 commented Oct 19, 2020

Thanks and of course!

I'll check the code, clean it a little and push PRs to the respective addons.

ofxMidi was forked just in case, but i haven't changed anything, so i will switch to the original one in the readmes and in the Mosaic installer scripts.

ofxGLEditor just opened a PR with the only changes in my fork, a simple compile fix.

ofxLua is a little bit tricky, my fork is actually old ( from 2018 ) so i'll need to check your last code, and adapt my commits to create a proper PR. I'm away from work right now, so i'll do this when i'll be back in November.

@d3cod3
Copy link
Owner

d3cod3 commented Nov 1, 2020

Just updated references for ofxGLEditor and ofxMidi on READMEs and scripts, i'll work next week on ofxLua.

@d3cod3
Copy link
Owner

d3cod3 commented Nov 28, 2022

Just updated to your original repo of ofxLua, so no forks anymore!

@d3cod3 d3cod3 closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants