Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move development dependencies to devDependencies #58

Closed
arnivuo opened this issue Oct 22, 2016 · 4 comments
Closed

Move development dependencies to devDependencies #58

arnivuo opened this issue Oct 22, 2016 · 4 comments
Assignees
Labels

Comments

@arnivuo
Copy link

arnivuo commented Oct 22, 2016

Hi,

Would it be possible to move dependencies that the end npm package user doesn't need to devDependencies. Now this package is forcing to install Electron (over 250 MB), Browserify, Babelify, ESLint, LiveServer, Faucet, Rollup, Tape, UglifyJS etc. for nothing.

Or is it that d3plus-common and d3plus-text should not be used via npm?

@davelandry
Copy link
Member

@arnivuo good find. I'll make the switch.

@davelandry
Copy link
Member

@arnivuo now that I've separated out the devDependencies, I'm having an issue using the bin scripts in other repos (like d3plus-text). You'll notice that the "test" script in that repo uses d3plus-common's d3plus-test script, and when that runs, it gets an error because one of the devDependencies is not installed.

I think we need to move towards having to npm i -g d3plus-common when developing, which I'm ok with, but I still can't get that test script to work in a different repo. Any thoughts?

@davelandry
Copy link
Member

@arnivuo after some thought, I'm going to be separating our the scripts to separate dev repo.

@arnivuo
Copy link
Author

arnivuo commented Nov 4, 2016

Hi, sorry missed your comment.

I noticed issue with bin scripts but didn't have any good idea how deal with those. That separate dev repo sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants