AppCleaner: Fix inconsistencies when using ACS and Shizuku #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Inaccessible caches" already includes the public default cache size.
…he matches as they were deleted too.
…n `InaccessibleCache` (contains public and private default caches) and `DefaultCachesPublicFilter`. Both affect each other and this needs to be taken into account when deleting either, i.e. remove entries and recalculate sizes.
d4rken
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue is/was that without root we can't access "inaccessible caches", which are the default public and private caches of an app. The caches that get cleared when pressing the "Clear cache" button in the system.
If we throw Shizuku into the mix, then we can access the PUBLIC default caches, but not the private default caches.
So with Shizuku the inaccessible caches entry overlaps with the public default caches.
Default cachesentry, then we also need to remove thePublic default cachesentryPublic default cachesentry, then we need to subtract the size from theDefault cachesentry.