This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Markdown in Descriptions #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update descriptionColumnParser tests |
d4rken
approved these changes
Aug 23, 2017
|
|
||
| public String fixHtmlEscapes(String input) { | ||
| //noinspection deprecation | ||
| return Html.fromHtml(input).toString(); | ||
| } | ||
|
|
||
| public String convertStringToHtml(String string) { | ||
| // Converts link markdown to HTML | ||
| String output = string; |
There was a problem hiding this comment.
I'm not too sure actually, I thought it would help with clarity to make it obvious that the string coming out was different, though I guess it's not really necessary
|
|
||
| public String convertSubredditsToLinks(String string) { | ||
| // Converts subreddit mentions to links in HTML | ||
| String output = string; |
There was a problem hiding this comment.
Same here, why the extra variable
| description.setText(appInfo.getDescription()); | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) | ||
| description.setText(Html.fromHtml(appInfo.getDescription(), Html.FROM_HTML_MODE_COMPACT)); |
There was a problem hiding this comment.
IF without brackets -> all one the same.
I don't always do it myself but it is a good practice for code reviews.
| AppInfo app3 = new AppInfo(); | ||
| app3.setAppName("Markdown Test"); | ||
| app3.setDescription( | ||
| encodingFixer.convertStringToHtml("Tutorial **screencast** for [Propellerheads Reason](https://www.propellerheads.se/products/reason/)")); |
There was a problem hiding this comment.
if a call is this long, and a line break is necessary maybe make it:
app3.setDescription(
encodingFixer.convertStringToHtml("Tutorial **screencast** for [Propellerheads Reason](https://www.propellerheads.se/products/reason/)")
);
bobheadxi
added a commit
that referenced
this pull request
Sep 6, 2017
* Convert bold and link markdown to HTML equivalents (handled by EncodingFixer) * Subreddit mentions (eg "/r/Android") are converted to HTML links * Support for HTML app descriptions in App Details view and App List view * Clickable links in app details view * Unit tests for changes, updates to other tests and mocks
bobheadxi
added a commit
that referenced
this pull request
Sep 6, 2017
bobheadxi
added a commit
that referenced
this pull request
Sep 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#8 - Deal with markdown in descriptions
Changes
EncodingFixer)