Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features: Configurable separator, regex matching, collision detection #7

Closed
wants to merge 6 commits into from

Conversation

skullydazed
Copy link

  • Wrapped the main loop in a try...Except so that it keeps going in the face of errors
  • Added --match to allow you to limit the run to certain files
  • Detect duplicate files and write them to a separate filename
  • Make the Artist-Title separator configurable
  • Added --no-match-prefix for renaming files with a prefix when no match is found

If any of my changes are a step too far feel free to ask for changes. I did this to solve my current (one off) problem of combining several music libraries into one. These changes were made to support the following workflow:

  • Generate a list of all current mp3 files
  • Generate md5sums for each mp3
  • Copy every unique file into a central directory named after the md5
  • Run idntag
    • During the run any file that was "no matches found" will have been renamed to no longer match my regex, allowing me to stop and restart at will without duplicating work
    • Any file that starts with my --no-match-prefix will be manually processed
    • If there are any files that are still just an md5 hash I can surmise that it received an API error and run the script again, where presumably most remaining files will work

Thanks for writing the original program, it saved me a ton of work! Hope these changes are useful to you or someone else in the future too.

* Wrapped the main loop in a try...Except so that it keeps going
* Added a regex match to allow you to limit the run to certain files
* Detect duplicate files and write them to a separate filename
* Make the Artist-Title separator configurable
@d99kris d99kris self-assigned this Jun 18, 2022
@d99kris
Copy link
Owner

d99kris commented Jun 18, 2022

Hi @skullydazed - thanks for contributing!

I've been on vacation, but will take a look at the PR soonish.

@skullydazed
Copy link
Author

No worries, I just got back from a vacation myself. There's no hurry from my side.

@d99kris
Copy link
Owner

d99kris commented Dec 9, 2022

Hi again - and apologies for the long delay.

I think the current PR extends the functionality of idntag in ways I did not have in mind, so unfortunately I cannot accept it as-is.

It's good you shared the PR though, for future users googling about functionality. They may find it and can use the modifications you suggested.

I will proceed to close this PR. If you'd still like to get some parts merged, feel free to re-open it and we can discuss how we can split it into separate parts with accompanying separate bugs / feature requests.

Best regards,
Kris

@d99kris d99kris closed this Dec 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants