Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spend proposal templates should use human readable amounts #59

Closed
JakeHartnell opened this issue Nov 21, 2021 · 4 comments · Fixed by #86
Closed

Spend proposal templates should use human readable amounts #59

JakeHartnell opened this issue Nov 21, 2021 · 4 comments · Fixed by #86
Labels
easy enhancement New feature or request

Comments

@JakeHartnell
Copy link
Member

Going through things, really think we should just use human readable amounts everywhere. Otherwise it's confusing to explain to a user that 1 ujunox is equal to 0.0000001 JUNOX.

@JakeHartnell JakeHartnell added easy enhancement New feature or request labels Nov 23, 2021
@JakeHartnell JakeHartnell added this to the Real Artists Ship milestone Nov 23, 2021
@0xekez 0xekez assigned 0xekez and unassigned 0xekez Nov 26, 2021
@0xekez
Copy link
Contributor

0xekez commented Dec 2, 2021

I believe that this is currently controlled by what the NEXT_PUBLIC_STAKING_DENOM environment variable is set to. For example, setting:

NEXT_PUBLIC_STAKING_DENOM="junox"

Results in spend proposals that use junox:

image

@JakeHartnell - I'm unfamiliar with the whole codebase so possible it would break other things - would changing that environment variable in the .env file fix this issue?

@JakeHartnell
Copy link
Member Author

I believe that this is currently controlled by what the NEXT_PUBLIC_STAKING_DENOM environment variable is set to. For example, setting:

NEXT_PUBLIC_STAKING_DENOM="junox"

Results in spend proposals that use junox:

image

@JakeHartnell - I'm unfamiliar with the whole codebase so possible it would break other things - would changing that environment variable in the .env file fix this issue?

This won't work. : )

Chain / contracts expect the amounts in the micro unit.

@0xekez
Copy link
Contributor

0xekez commented Dec 2, 2021

Chain / contracts expect the amounts in the micro unit.

Learn something new every day :) Am I correct in understanding then that the goal of this is to have the user input amounts in juno and then have the ui convert / use ujuno under the hood?

@JakeHartnell
Copy link
Member Author

Chain / contracts expect the amounts in the micro unit.

Learn something new every day :) Am I correct in understanding then that the goal of this is to have the user input amounts in juno and then have the ui convert / use ujuno under the hood?

Yes!

0xekez added a commit that referenced this issue Dec 3, 2021
JakeHartnell added a commit that referenced this issue Dec 3, 2021
Use human readable forms for spend proposals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants