Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sleep statements #1

Closed
flowchartsman opened this issue Aug 22, 2012 · 3 comments
Closed

Multiple sleep statements #1

flowchartsman opened this issue Aug 22, 2012 · 3 comments

Comments

@flowchartsman
Copy link
Contributor

All of those "sleep 2" lines seem unnecessary to me. I suppose you could make a case for allowing the user time to abort at any step or for giving them time to read the output, but I don't think either of these are valid concerns. If I'm building something, I don't really care very much about success messages and, if I do, I'll pipe it through less. If it bails on error, then the terminal will be left sitting on the relevant data anyway.

@da667
Copy link
Owner

da667 commented Aug 22, 2012

Will agree to this. I do want to leave the initial sleep statement warning the user if the script is ran on a non-ubuntu system, and the sleep statement reminding the user what the snort mysql user's password is. A reasonable compromise?

@flowchartsman
Copy link
Contributor Author

Don't sleep for informational purposes. Use a read to prompt for the first, and echo the mysql password at the very end.

@flowchartsman
Copy link
Contributor Author

Pull request submitted for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants