-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddToThis replcaing the share buttons #1296
Comments
@monksy transferring this to be an issue |
It's a good idea, and I do like their lightweight design. |
@daattali It seems that you already have a similar solution with respect to your use of the external url and css files. You check if the given attribute is a simple entry or an object. You could extend this feature using the same technique. For example let's use the email link thus you can go from: social-network-links: to social-network-links: such that your check will be able to determine if the email field is the first case or the second case like you do with you ext-js.html include file. The other suggestion is that you can create a general include file that will be able to generate the li entry. Looking at the social-network-links.html include file. It is clear that you have several fields that you can define like:
The above will make it easier to add and update the format for the generated li entry. |
Thanks for your input @ccorsi. While the AddToThis library is nice, I've come to the conclusion by now that it's not actually very necessary. It gets difficult to strike the balance between being feature-rich and being simple, and I'd prefer to keep this more on the simple side and keep the config as-is. |
Discussed in #1283
Originally posted by monksy January 30, 2024
I was asking for enhancements for the share buttons, but this might look like a better way to handle that situation:
https://www.addtoany.com/
Thoughts?
The text was updated successfully, but these errors were encountered: