Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the demo, siblings collapse into each other #16

Closed
DoDSoftware opened this issue May 9, 2016 · 2 comments
Closed

In the demo, siblings collapse into each other #16

DoDSoftware opened this issue May 9, 2016 · 2 comments

Comments

@DoDSoftware
Copy link

In the demo located at http://dabeng.github.io/OrgChart/drag-drop/ clicking the infacing arrows on either side of an element will collapse all of that elements siblings into the clicked element.

It seems that this is intended behaviour as if meant to focus on the selected node and its children but it strikes me counter-intuitive. This behaviour makes it seem like the hidden elements are children of the clicked element not its siblings which is not the case.

I feel like this will cause confusion with my users. I would need to make one of the following changes in order to use this:

  1. Hide the left and right arrow using CSS to eliminate confusion
  2. Change the left and right icons from an arrow to something that more intuitively suggests a focusing action, like a magnifying glass perhaps

screenshot at may 09 12-43-57

@dabeng
Copy link
Owner

dabeng commented May 10, 2016

Hi @DelightedD0D . Thank you so much for your deep and detailed analysis about expand/collapse nodes feature.
While, left&right arrows help users to expand/collapse sibling nodes, top arrow expands/collapses ancestor node, bottom arrow expands/collapses descendant nodes, all of those are basic parts of core behavior of OrgChart plugin that shouldn't be modified lightly.

Imagine if siblings nodes are hided and their child nodes are not hided, it's indeed a weird user experience and cause confusion.

@dabeng dabeng closed this as completed May 11, 2016
@DoDSoftware
Copy link
Author

I get what you're going for but it looks odd. In the image on the right, with the siblings collapsed, There's no indication that elements are hidden it just looks like "Chun Miao" only has one child. Overall, great job. My only critique is just that there could be something to show that one sibling is focused and that there are others that are hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants