Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Object.defineProperty method instead of __defineGetter__ #17

Open
rilysh opened this issue May 30, 2022 · 0 comments
Open

Use Object.defineProperty method instead of __defineGetter__ #17

rilysh opened this issue May 30, 2022 · 0 comments

Comments

@rilysh
Copy link

rilysh commented May 30, 2022

colors.js/lib/extendStringPrototype.js

Line 8 in ba784a1

String.prototype.__defineGetter__(color, func);

As we know that prototype.__defineGetter__ was been deprecated. Currently it's on legacy version. By using Object.defineProperty with a getter function can be much more better than __defineGetter__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rilysh