-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for discrete_scatter #176
Conversation
Apparently, I broke the build... I will have a look. Also I noticed the arguments |
Thanks, fixing the docs would be very welcome as well! |
Seems like a regression in pandas 1.0 that broke CI: pandas-dev/pandas#31469 |
can you please do another commit to trigger CI again? I just moved the repo to its own org which reset all the CI. |
hm the failure is related to your change though I'm not entirely sure what's going on. Looks like a bug in the discrete_scatter code maybe? |
Couldn't reproduce the error locally. Sex might also not be a good example for a scatterplot given that it's categorical. It might work after #175 but right now it'd look pretty boring. |
If you merge master, the error will go away. I pushed a work-around. And yes, that example looks great, thanks! |
4dd43cb
to
d8868b9
Compare
I had to create the figure using |
That's a bit odd but looks good now! Thanks! |
Fix #166 by adding an example file using the
titanic
dataset and also extending the dosctring ofdiscrete_scatter
with said example.