Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for discrete_scatter #176

Merged
merged 1 commit into from Jan 31, 2020
Merged

Add example for discrete_scatter #176

merged 1 commit into from Jan 31, 2020

Conversation

SvoONs
Copy link
Contributor

@SvoONs SvoONs commented Jan 30, 2020

Fix #166 by adding an example file using the titanic dataset and also extending the dosctring of discrete_scatter with said example.

@SvoONs
Copy link
Contributor Author

SvoONs commented Jan 30, 2020

Apparently, I broke the build... I will have a look. Also I noticed the arguments unique_c and clip_outliers are not documented yet, I will come up with proposals.

@amueller
Copy link
Collaborator

Thanks, fixing the docs would be very welcome as well!
Hm the same failure is in #180 I must have messed this up myself.

@amueller
Copy link
Collaborator

Seems like a regression in pandas 1.0 that broke CI: pandas-dev/pandas#31469

@amueller
Copy link
Collaborator

can you please do another commit to trigger CI again? I just moved the repo to its own org which reset all the CI.

@amueller
Copy link
Collaborator

hm the failure is related to your change though I'm not entirely sure what's going on. Looks like a bug in the discrete_scatter code maybe?

@amueller
Copy link
Collaborator

Couldn't reproduce the error locally. Sex might also not be a good example for a scatterplot given that it's categorical. It might work after #175 but right now it'd look pretty boring.

@SvoONs
Copy link
Contributor Author

SvoONs commented Jan 31, 2020

I can reproduce the error locally using pandas==1.0.0. If I downpin pandas tests pass.
I picked a different dataset for the example, let me know what you think.
test

@amueller
Copy link
Collaborator

If you merge master, the error will go away. I pushed a work-around. And yes, that example looks great, thanks!

@SvoONs SvoONs force-pushed the master branch 4 times, most recently from 4dd43cb to d8868b9 Compare January 31, 2020 20:03
@SvoONs
Copy link
Contributor Author

SvoONs commented Jan 31, 2020

I had to create the figure using plt.figure() in the docstring example in order to make doctest pass. In my local setup it also works without, a bit weird.

@amueller
Copy link
Collaborator

That's a bit odd but looks good now! Thanks!

@amueller amueller merged commit 880abe0 into dabl:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add example for discrete_scatter
2 participants