Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegisterMany should indicate if no registration was made #9

Closed
dadhi opened this issue Aug 17, 2018 · 0 comments
Closed

RegisterMany should indicate if no registration was made #9

dadhi opened this issue Aug 17, 2018 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@dadhi
Copy link
Owner

dadhi commented Aug 17, 2018

Currently it does nothing if no registration was made, when no implementation and no service types to register were detected.
This seems wrong, as the User expects the method to do something.
Throwing the exception in this case may be a breaking, but better to inform the User earlier than to keep a silence and got an eventual surprise later.

@dadhi dadhi self-assigned this Aug 17, 2018
@dadhi dadhi added bug Something isn't working enhancement New feature or request labels Aug 17, 2018
@dadhi dadhi added this to the 3.1.0 milestone Aug 17, 2018
@dadhi dadhi closed this as completed in 1e38198 Aug 18, 2018
@dadhi dadhi modified the milestones: 3.1.0, 4.0.0 Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant