Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: If no kid is present in the JWT, the jwt_authenticator can now iterate over the received JWKS and try to verify the signature until one of the keys matches #196

Merged
merged 9 commits into from
Aug 23, 2022
Merged

feat: If no kid is present in the JWT, the jwt_authenticator can now iterate over the received JWKS and try to verify the signature until one of the keys matches #196

merged 9 commits into from
Aug 23, 2022

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Aug 22, 2022

closes: #99

@codecov
Copy link

codecov bot commented Aug 22, 2022 •
edited
Loading

Codecov Report

Merging #196 (0babd19) into main (9541920) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   84.91%   85.16%   +0.24%     
==========================================
  Files         157      157              
  Lines        6167     6208      +41     
==========================================
+ Hits         5237     5287      +50     
+ Misses        787      779       -8     
+ Partials      143      142       -1
Impacted Files Coverage Δ
...ernal/pipeline/authenticators/jwt_authenticator.go 92.70% <100.00%> (+2.46%) ⬆️
internal/testsupport/pem_builder.go 59.67% <100.00%> (+6.84%) ⬆️
internal/rules/repository.go 97.60% <0.00%> (+3.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus changed the title feat: If not kid is present in the JWT, the jwt_authenticator can now iterate over the received JWKS and try to verify the signature until one of the keys matches feat: If no kid is present in the JWT, the jwt_authenticator can now iterate over the received JWKS and try to verify the signature until one of the keys matches Aug 23, 2022
@dadrus dadrus merged commit 488e46f into main Aug 23, 2022
@dadrus dadrus deleted the feat/jwt_without_kid branch August 23, 2022 19:48
@github-actions github-actions bot mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dadrus