-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reverse proxy support #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 85.02% 85.48% +0.46%
==========================================
Files 141 146 +5
Lines 5221 5449 +228
==========================================
+ Hits 4439 4658 +219
- Misses 667 672 +5
- Partials 115 119 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
… to avoid clashes
…implement requirements of the decision api and the proxy handler
…x-forwarded-for and forwarded header
…etrieved from fiber context
…rusted proxies was unfortunately impossible.
… of X-Forwarded-* and Forwarded headers
…n new ideas and insights from tests
…arded and X-Forwarded-For header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4
closes #96
TODOs:
X-Forwarded-For
header only if it is present. Otherwise use theForwarded
header, which superseded theX-Forwarded-For
headerX-Forwarded-Method
,X-Forwarded-Proto
,X-Forwarded-Host
,X-Forwarded-Uri
andX-Forwarded-Path
from the request forwarded to the upstream service. These header are useless for it as these contain the URL parts, heimdall is using to connect.