-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: unifier
renamed to finalizer
#956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #956 +/- ##
==========================================
- Coverage 89.82% 89.82% -0.01%
==========================================
Files 234 234
Lines 9652 9650 -2
==========================================
- Hits 8670 8668 -2
Misses 762 762
Partials 220 220
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
relates to #882
Checklist
Description
Initially, unifiers were acting on a
Subject
object only. For that reason the nameunifier
has been chosen to reflect their purpose - to unify the information about the subject into a format required by the upstream service.Meanwhile, unifiers has access to the
Request
object as well and it is up to the integrator, how to configure them. There are cases, where the upstream service doesn't need any information about the subject, but just a specific header from the original request.In the future, when #882 is implemented, heimdall can be used to make use of e.g. API keys or drive OAuth2 Client Credentials Flow to get a token required for communication with an upstream service in the last step of the pipeline, which is completely independent from the subject authenticated so far.
That also means, the name
unifier
has already lost its initial meaning and will lead to even more confusion in the future. For that reason, this PR renames the last step of the pipeline tofinalizer
, which is also a breaking change.For the heimdall's configuration file that change means
become
And for the rule sets, that change means, that finalizers are referenced by the key word
finalizer
(wasunifier
before).So
become