-
Notifications
You must be signed in to change notification settings - Fork 62
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMICO Maps histograms general question- Not an issue #8
Comments
Dear Prasanna, I think this is an effect of the discretization in the dictionary. When you apply the l1 norm to promote sparsity in the solution, only some atoms are retained from all possible combinations that are considered. I had observed similar spikes also in the original NODDI fitting, especially in the OD parameter, where the values attributed to CSF is always the same. Best, |
Dear Prasanna, sorry for my delay, I am at the moment on kind of "paternity leave" and have had not much time to work. Sorry for that; I'm trying to catch up with work as fast as I can! What you highlight seems to me related to the discretization AMICO uses in the dictionary. I think the spikes are generated by this discretization that somehow limits the possible output values for the parameters. These values seem in fact widely spread in the brain, and not concentrated in any specific location. Surely there are differences between the original model and the aMICO approximation (as I previously described), but this is another topic. Do you think this could badly influence your analyses? On a side note, we have recently developed an alternative way to fit models within AMICO that can enforce, for free, spatial regularization of the estimations in each voxel; this might help also with the issue you describe here. We have not tested this method yet, but I will speak with @ejcanalesr (the actual person who developed this new solver) and I will discuss with him about its applicability to mitigate the discretization issue you have described. I will keep you posted! |
Hello Dr. Daducci, Thank you for looking into this. We are comparing the response from both NODDI and AMICO to determine if current NODDI processing can be replaced with AMICO as this is the faster version of NODDI or if there are areas that we need to be cautious about in analyzing the results in tumor regions in addition to normal brain processing. Will keep you posted once we do quantitative analysis in tumor regions. Appreciate your feedback. Thanks, |
Dear Prasanna, did you finally got any useful information from the comparison between AMICO and NODDI implementations? |
Hello Dr. Daducci,
Can you please suggest if there are any parameters we could adjust to make these two results match. Thanks, |
To follow up on this, I have run into the same issue with discretization in the ICVF and ODI (running the python version of AMICO). Has there been any progress on optimal paramteres or the method by @ejcanalesr? same comparison, with mean gaussian smoothing of the AMICO OD ouptut, kernel size from left to right = 0.75, 1, 2mm (data resolution = 2x2x2) |
Hello Dr. Dadduci, Can you please point us to the method proposed by @ejcanalesr, we can plan to include it in further analysis. Thanks, |
Hello Dr. Prasanna, Erick J. Canales-Rodríguez www.fidmag.org http://www.fidmag.org/ Ley de protección de datos: 2016-06-12 18:45 GMT+02:00 goals2008 notifications@github.com:
|
Dear Prasanna, we have started looking into this issue and we have a question for you. We noticed that in your plots the OD index is about 0.7 whereas in the maps released with the tutorial data OD is about 1. Which version of the code and matlab are you using? Thanks, |
Hello, Thank you for looking into this issue. We are using following Matlab Please let me know if you need more information. Thanks, On Thu, Jul 14, 2016 at 4:47 AM, Alessandro Daducci <
|
Dear Prasanna, We have been working on the issue you reported. Fortunately, we have found As we have tested this preliminar version only in our data (as well as in Please, could you send us the data you have used to create the figures We plan to update the toolbox as soon as possible, after verify the Thank you very much for your valuable contribution! Regards, P.S. Please, find attached here a preliminary result from our evaluation Notice that after recomputing the OD maps with the original NODDI, in CSF |
Sure, I will be happy to test this out, please do share the updated code. I dont have access to the original data right now, but could send you another dataset soon. Thanks, |
This looks great - I would be happy to test as well on HCP data and a 3-shell 2mm dataset that we have collected in-house. I have been using the python version of AMICO, but would also be open to testing the matlab version. Chirs |
Thanks @goals2008 and @steelec for your help!
Sounds good? |
Yes, that sounds good. Thanks
|
Perfect. On Fri, Jul 29, 2016, 13:56 goals2008 notifications@github.com wrote:
Chris |
Here is the test data having similar results. Please let us know if you see https://www.dropbox.com/s/xlxnu1hoaxciuwa/TestData_MASI.zip?dl=0 Thanks, On Fri, Jul 29, 2016 at 7:24 AM, steelec notifications@github.com wrote:
|
Hello Dr. Daducci, Can you please let us know if there is any additional information you are looking for or if there is any testing we could do for this fix. Thanks, |
Hi, we have finished the internal evaluation step (first step proposed by @daducci in the previous post) by using different datasets (thanks @goals2008 and @steelec!). Result from the "example dataset" included as part of the original NODDI toolbox |
Great to hear! |
Hello Canales,
Thanks
|
Dear @goals2008 and @steelec, please find attached here the new code. Short explanation (MATLAB toolbox):
The readme.txt file contains more details... |
Thank you for providing the updated code and detailed instructions. Will Thanks, On Wed, Sep 7, 2016 at 9:23 AM, Erick J Canales-Rodríguez <
|
I can do the same ASAP if you also have a python version, otherwise I can probably get to testing the matlab version sometime late next week. Thanks very much! |
Hi @goals2008 and @steelec , the code is just an "internal test" for the moment, so it's been prototyped in MATLAB to have a quick version asap (we are more familiar with MATLAB than python). Then, if you can confirm the improved results we have observed, we will proceed to porting it to python as well. Thanks a lot for you help! |
Hi Erick, Sorry for the delay. I had to re-setup my AMICO/spams Matlab environment I got it running for both original and new model and results are looking Thanks, On Wed, Sep 7, 2016 at 9:23 AM, Erick J Canales-Rodríguez <
|
I don't think it was attached...? |
I have attached 2 screenshots having ICVF and ODI histogram and qualitative
Reattaching them.. can you please confirm if you still see issue accessing Thanks, On Sat, Oct 8, 2016 at 9:13 AM, Christopher J. Steele <
|
I don't see it here. weird. |
I don't see any attachment either. |
Hi goals2008, |
Yes. Thanks, |
Hi Erick,
Just checking if the fix you have made earlier is available in python
version or in the official matlab version.
Appreciate your efforts.
Thanks,
Prasanna
…On Sat, Oct 8, 2016 at 9:41 AM, Prasanna ***@***.***> wrote:
I have attached 2 screenshots having ICVF and ODI histogram and
qualitative image
- AMICO_Orig
- AMICO_New
Reattaching them.. can you please confirm if you still see issue accessing
them.
Thanks,
Prasanna
On Sat, Oct 8, 2016 at 9:13 AM, Christopher J. Steele <
***@***.***> wrote:
> I don't think it was attached...?
> Sorry for my slowness on testing as well, probably will be able to do
> some more testing in about 2 weeks.
> Chris
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#8 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AKY0HQyqgInks9yCxiiDpRcDoQTUmZO_ks5qx6UmgaJpZM4FwQyD>
> .
>
|
Dear Prasanna,
The fix is not available in the official release yet.
However, we are working in a new different implementation that includes a Rician noise model, and spatial regularization for noise datasets, which may replace that fix.
We are very close to have the final version but still we need some time to test it in different datasets.
Thank you very much for your interest!
Regards,
Erick
________________________________
From: goals2008 <notifications@github.com>
Sent: Saturday, March 18, 2017 3:34 AM
To: daducci/AMICO
Cc: Canales Rodriguez Erick Jorge; Assign
Subject: Re: [daducci/AMICO] AMICO Maps histograms general question- Not an issue (#8)
Hi Erick,
Just checking if the fix you have made earlier is available in python
version or in the official matlab version.
Appreciate your efforts.
Thanks,
Prasanna
On Sat, Oct 8, 2016 at 9:41 AM, Prasanna ***@***.***> wrote:
I have attached 2 screenshots having ICVF and ODI histogram and
qualitative image
- AMICO_Orig
- AMICO_New
Reattaching them.. can you please confirm if you still see issue accessing
them.
Thanks,
Prasanna
On Sat, Oct 8, 2016 at 9:13 AM, Christopher J. Steele <
***@***.***> wrote:
> I don't think it was attached...?
> Sorry for my slowness on testing as well, probably will be able to do
> some more testing in about 2 weeks.
> Chris
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#8 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AKY0HQyqgInks9yCxiiDpRcDoQTUmZO_ks5qx6UmgaJpZM4FwQyD>
> .
>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIqLrSWkoNGDJ_ylXRs2NnbBtoMjhmSEks5rm0K6gaJpZM4FwQyD>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/daducci/AMICO","title":"daducci/AMICO","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/daducci/AMICO"}},"updates":{"snippets":[{"icon":"PERSON","message":"@goals2008 in #8: Hi Erick,\n\n Just checking if the fix you have made earlier is available in python\nversion or in the official matlab version.\n\nAppreciate your efforts.\n\nThanks,\nPrasanna\n\nOn Sat, Oct 8, 2016 at 9:41 AM, Prasanna \u003cgoals2008@gmail.com\u003e wrote:\n\n\u003e I have attached 2 screenshots having ICVF and ODI histogram and\n\u003e qualitative image\n\u003e\n\u003e - AMICO_Orig\n\u003e - AMICO_New\n\u003e\n\u003e Reattaching them.. can you please confirm if you still see issue accessing\n\u003e them.\n\u003e\n\u003e Thanks,\n\u003e Prasanna\n\u003e\n\u003e On Sat, Oct 8, 2016 at 9:13 AM, Christopher J. Steele \u003c\n\u003e notifications@github.com\u003e wrote:\n\u003e\n\u003e\u003e I don't think it was attached...?\n\u003e\u003e Sorry for my slowness on testing as well, probably will be able to do\n\u003e\u003e some more testing in about 2 weeks.\n\u003e\u003e Chris\n\u003e\u003e\n\u003e\u003e —\n\u003e\u003e You are receiving this because you were mentioned.\n\u003e\u003e Reply to this email directly, view it on GitHub\n\u003e\u003e \u003chttps://github.com/daducci/AMICO/issues/8#issuecomment-252426723\u003e, or mute\n\u003e\u003e the thread\n\u003e\u003e \u003chttps://github.com/notifications/unsubscribe-auth/AKY0HQyqgInks9yCxiiDpRcDoQTUmZO_ks5qx6UmgaJpZM4FwQyD\u003e\n\u003e\u003e .\n\u003e\u003e\n\u003e\n\u003e\n"}],"action":{"name":"View Issue","url":"#8 (comment)"}}}
|
Thank you Erick! Its great to know that it will be available soon!
On Tue, Mar 21, 2017 at 5:58 AM, Erick J Canales-Rodríguez <
notifications@github.com> wrote:
… Dear Prasanna,
The fix is not available in the official release yet.
However, we are working in a new different implementation that includes a
Rician noise model, and spatial regularization for noise datasets, which
may replace that fix.
We are very close to have the final version but still we need some time to
test it in different datasets.
Thank you very much for your interest!
Regards,
Erick
________________________________
From: goals2008 ***@***.***>
Sent: Saturday, March 18, 2017 3:34 AM
To: daducci/AMICO
Cc: Canales Rodriguez Erick Jorge; Assign
Subject: Re: [daducci/AMICO] AMICO Maps histograms general question- Not
an issue (#8)
Hi Erick,
Just checking if the fix you have made earlier is available in python
version or in the official matlab version.
Appreciate your efforts.
Thanks,
Prasanna
On Sat, Oct 8, 2016 at 9:41 AM, Prasanna ***@***.***> wrote:
> I have attached 2 screenshots having ICVF and ODI histogram and
> qualitative image
>
> - AMICO_Orig
> - AMICO_New
>
> Reattaching them.. can you please confirm if you still see issue
accessing
> them.
>
> Thanks,
> Prasanna
>
> On Sat, Oct 8, 2016 at 9:13 AM, Christopher J. Steele <
> ***@***.***> wrote:
>
>> I don't think it was attached...?
>> Sorry for my slowness on testing as well, probably will be able to do
>> some more testing in about 2 weeks.
>> Chris
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#8 (comment)>, or
mute
>> the thread
>> <https://github.com/notifications/unsubscribe-auth/
AKY0HQyqgInks9yCxiiDpRcDoQTUmZO_ks5qx6UmgaJpZM4FwQyD>
>> .
>>
>
>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<https://github.com/
daducci/AMICO#8#issuecomment-287510606>, or mute the thread<
https://github.com/notifications/unsubscribe-auth/AIqLrSWkoNGDJ_
ylXRs2NnbBtoMjhmSEks5rm0K6gaJpZM4FwQyD>.
{"api_version":"1.0","publisher":{"api_key":"
05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":
{"external_key":"github/daducci/AMICO","title":"
daducci/AMICO","subtitle":"GitHub repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-
11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://
cloud.githubusercontent.com/assets/143418/15842166/
7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/daducci/AMICO"}},"updates"
***@***.*** in #8: Hi Erick,\n\n
Just checking if the fix you have made earlier is available in
python\nversion or in the official matlab version.\n\nAppreciate your
efforts.\n\nThanks,\nPrasanna\n\nOn Sat, Oct 8, 2016 at 9:41 AM, Prasanna
***@***.***\u003e wrote:\n\n\u003e I have attached 2
screenshots having ICVF and ODI histogram and\n\u003e qualitative
image\n\u003e\n\u003e - AMICO_Orig\n\u003e - AMICO_New\n\u003e\n\u003e
Reattaching them.. can you please confirm if you still see issue
accessing\n\u003e them.\n\u003e\n\u003e Thanks,\n\u003e
Prasanna\n\u003e\n\u003e On Sat, Oct 8, 2016 at 9:13 AM, Christopher J.
Steele \u003c\n\u003e ***@***.***\u003e
wrote:\n\u003e\n\u003e\u003e I don't think it was
attached...?\n\u003e\u003e Sorry for my slowness on testing as well,
probably will be able to do\n\u003e\u003e some more testing in about 2
weeks.\n\u003e\u003e Chris\n\u003e\u003e\n\u003e\u003e —\n\u003e\u003e
You are receiving this because you were mentioned.\n\u003e\u003e Reply to
this email directly, view it on GitHub\n\u003e\u003e \u003chttps://
github.com/daducci/AMICO/issues/8#issuecomment-252426723\u003e
<http://github.com/daducci/AMICO/issues/8#issuecomment-252426723%5Cu003e>,
or mute\n\u003e\u003e the thread\n\u003e\u003e \u003chttps://github.com/
notifications/unsubscribe-auth/AKY0HQyqgInks9yCxiiDpRcDoQTUmZ
O_ks5qx6UmgaJpZM4FwQyD\u003e\n\u003e\u003e
<http://github.com/notifications/unsubscribe-auth/AKY0HQyqgInks9yCxiiDpRcDoQTUmZO_ks5qx6UmgaJpZM4FwQyD%5Cu003e%5Cn%5Cu003e%5Cu003e>
.\n\u003e\u003e\n\u003e\n\u003e\n"}],"action":{"name":"View Issue","url":"
#8 (comment)"}}}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKY0HYAnX5dWcCzx5eoC6sAF4gkX73z2ks5rn61igaJpZM4FwQyD>
.
|
This issue is about to reach its anniversary. thanks and please let us know how we can help. |
Bump -- any progress on this? |
Hi, I'm also curious whether there has been any progress on this, especially in the python version. I greatly appreciate the speed and stability of the AMICO implementation of NODDI, but it seems as if it is sometimes too stable and prefers certain values. We would like to make comparisons within a set of scans for a study, but as you can see we have a problem with the ICVF (= NDI in the plot) having a predilection for certain values for many regions in the JHU "Eve" WM atlas: The plot shows the median ICVF of the voxels inside each atlas region vs. the number of voxels in that scans's region in subject space for 128 scans. I like to make these plots to check the quality of both model fitting and atlas registration, and usually expect to see blobbish clusters for each region. The orientation dispersion and ISOVF from AMICO NODDI are not showing any drastic quantization in their plots. Is there any way I can help? If it is delayed by the Rician noise model, I hope you will consider making a release without it, since I am already debiasing my input images. Thanks, Rob Reid |
My personal impression is that this issue cannot or will not be fixed. If you are looking for faster modelling of NODDI parameters and know how to setup GPU devices you may explore the Microstructure Diffusion Toolbox If you scroll half way down the FAQ page you'll see an example of NODDI modelling and their publication. An added benefit is the software allows testing many models and easily adding your own so it is an interesting way to explore your data and learn concepts if you are so inclined. |
Thanks! We are doing our diffusion processing with GPUs anyway because of eddy_cuda, but do have a bit of a road bump because the Microstructure Diffusion Toolbox requires python 3. We are using CentOS 7, and I know there are a few ways to install python 3 even on RHEL-based systems, but I will have to work with our system administrator a bit to figure something out. |
Dear @captainnova , indeed we have to apologize for the long silence!
The good news is that the problem can be solved, and in fact it was! We have had the code ready for long time now, but have no one to port it and integrate to AMICO. We will do our best to port it asap. As a side note, we are working also on porting AMICO to GPU, for an event more dramatic acceleration! We'll keep you posted of course. |
I'm glad to hear it! Thanks, Rob |
Dear @daducci , I am having the same issue with the discretization of ICVF values (I'm working on the HCP dataset). Is this implemented into the Python version of AMICO? Or is there a workaround I could use in the meantime (increasing the number of evenly spaced samples in np.linspace(0.1, 0.99, 12) from 12 to 50 maybe?) as mentioned in issue #97 #97 for a similar issue. I would greatly appreciate any help! Thank you, Stefanie |
Dear Stefanie, |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hello Dr. Daducci,
This is not an issue but general question in regard to histograms for the AMICO maps that are generated. There are spikes showing up at certain intervals for FICVF and OD histograms as attached. When we threshold the image for these values the data seem to be spread across the brain.
Can you please advice if this is expected.
Thanks,
Prasanna
The text was updated successfully, but these errors were encountered: