Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unix convention for tar modules #74

Closed
jfrohnhofen opened this issue Jun 15, 2021 · 2 comments · Fixed by #75
Closed

Support Unix convention for tar modules #74

jfrohnhofen opened this issue Jun 15, 2021 · 2 comments · Fixed by #75
Assignees
Labels
deps Related to dependency management enhancement New feature or request

Comments

@jfrohnhofen
Copy link
Contributor

In Unix it is convention to include a package directory in tarballs. To support this style in DBT, we need to remove that directory when extracting the tarball.

@jfrohnhofen jfrohnhofen added enhancement New feature or request deps Related to dependency management labels Jun 15, 2021
@ptia
Copy link
Contributor

ptia commented Jun 16, 2021

How do we want deal with existing dependencies that don't do this? Do we enforce the unix convention?

@jfrohnhofen
Copy link
Contributor Author

The only existing dependencies we currently have are the toolchains and some for HDL. Given that the number of ppl using DBT right now and the number of existing dependencies is small, I would do a breaking change and update the existing dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Related to dependency management enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants