Setting cores to 0 will use half of the available cores #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpitclaudel
requested changes
Dec 27, 2022
| @@ -40,7 +40,8 @@ public static class BoogieOptionBag { | |||
| o.Parse(SplitArguments(boogieOptions).ToArray()); | |||
| } | |||
| }); | |||
| DafnyOptions.RegisterLegacyBinding(Cores, (o, f) => o.VcsCores = f); | |||
| DafnyOptions.RegisterLegacyBinding(Cores, | |||
| (o, f) => o.VcsCores = f == 0 ? System.Environment.ProcessorCount / 2 : (int)f); | |||
There was a problem hiding this comment.
Shouldn't this round up? What happens on a machine with one core?
cpitclaudel
approved these changes
Dec 27, 2022
RustanLeino
pushed a commit
to RustanLeino/dafny
that referenced
this pull request
Dec 29, 2022
) Setting cores to 0 will use half of the available cores. <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting cores to 0 will use half of the available cores.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.