Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a temporary fix for verification cores set to 0 #332

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

keyboardDrummer
Copy link
Member

Introduce a temporary fix so setting verification cores to 0 (the default) doesn't stop verification

Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it because it's urgent but I would like to have a follow-up PR with a test to ensure that, if the number of cores is not specified, that the command line used to run DafnyLanguageServer is not set to zero cores.

@keyboardDrummer keyboardDrummer deleted the coresTempFix branch December 27, 2022 15:11
@keyboardDrummer
Copy link
Member Author

I'll approve it because it's urgent but I would like to have a follow-up PR with a test to ensure that, if the number of cores is not specified, that the command line used to run DafnyLanguageServer is not set to zero cores.

Note that we're also updating the language server to allow 0 cores: dafny-lang/dafny#3276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants