Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Resonant Shards are only revealed if you've obtained hummingstone, but you can trigger the Hymn using natural generation #395

Closed
Robotgiggle opened this issue May 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Robotgiggle
Copy link
Contributor

Robotgiggle commented May 20, 2024

Describe the bug
The advancement for triggering the Hummingstone Hymn, which also serves to reveal the Resonance Shards it drops, requires you to have the advancement for collecting hummingstone as a prerequisite. Presumably it's set up this way because the assumption is that you'd need to pick up a bunch of hummingstone and put it together to get enough resonance for the Hymn. However, it's actually possible to trigger the Hymn using only a natural hummingstone formation, and if you do so before ever obtaining hummingstone blocks, the dropped Resonance Shards will be shrouded and unusable.

To Reproduce

  • Find a particularly large natural hummingstone formation
  • Trigger the vibration effect
  • With enough hummingstone blocks, it'll all shatter and drop a bunch of shards
  • These shards will remain shrouded until you go mine a different hummingstone formation and obtain hummingstone blocks

Expected behavior
It would make a bit more sense if the only criteria for revealing the Resonance Shards was having triggered the Hymn. Removing the prerequisite here doesn't seem like it would allow for any new sequence breaks.

Minecraft version
1.20.1

Mod version
1.7.11

Screenshots
image

@Robotgiggle Robotgiggle added the bug Something isn't working label May 20, 2024
@DaFuqs DaFuqs closed this as completed in c07e136 May 25, 2024
DaFuqs added a commit that referenced this issue May 25, 2024
Update hummingstone hymn reqs to fix #395
DaFuqs pushed a commit that referenced this issue Jun 16, 2024
Now just requires you to progress to the DD and do the actual hummingstone hymn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant