Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build not working #33

Closed
coli opened this issue Mar 10, 2014 · 1 comment
Closed

build not working #33

coli opened this issue Mar 10, 2014 · 1 comment

Comments

@coli
Copy link

coli commented Mar 10, 2014

I think you forgot to checking the jshint config file?

Running "make"

I'm getting

  8 passing (4599ms)

mkdir -p build
./node_modules/jshint/bin/jshint browser.js index.js lib/version.js lib/Renderer.js lib/util.js
lib/Renderer.js: line 8, col 18, 'Renderer' was used before it was defined.
lib/Renderer.js: line 10, col 3, Missing "use strict" statement.
lib/Renderer.js: line 27, col 3, Missing "use strict" statement.
lib/Renderer.js: line 33, col 3, Missing "use strict" statement.
lib/Renderer.js: line 39, col 3, Missing "use strict" statement.
lib/Renderer.js: line 45, col 3, Missing "use strict" statement.
...
@cpettitt
Copy link
Collaborator

For some reason I didn't add a .jshintrc to the project, so on your box it must be picking one up from an ancestor directory. As you suggested, the best course of action is to add one. I found a few lint errors in the process. Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants