Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagster Running with Celery on Kubernetes, define_asset_job is not respecting dagster-k8s/config.pod_spec_config.tolerations #23298

Open
henrytseng opened this issue Jul 29, 2024 · 0 comments
Labels
deployment: k8s Related to deploying Dagster to Kubernetes type: bug Something isn't working

Comments

@henrytseng
Copy link

henrytseng commented Jul 29, 2024

Dagster version

1.7.15

What's the issue?

Using celery_k8s_job_executor

Running Dagster Running with Celery on Kubernetes using the Helm chart and using define_asset_job is not respecting tag defined in

define_asset_job(
    tags={
        "dagster-k8s/config": {
            "pod_spec_config": {
                "node_selector": {
                    "nodegroup": "memory-workers",
                },
                "tolerations": [
                    {
                        "key": "asdf/memory-workers",
                        "effect": "NoSchedule",
                    },
                    {
                        "key": "ops",
                        "value": "only",
                    },
                ],
            },
        },
        ...

Using the celery_k8s_job_executor with Definitions configured. The Job seems to run but without the Kubernetes tolerations.

What did you expect to happen?

Expecting tolerations to be added to job/pod manifest(s) or validation messages but no luck ATM.

How to reproduce?

No response

Deployment type

Dagster Helm chart

Deployment details

Dagster Running with Celery on Kubernetes

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@henrytseng henrytseng added the type: bug Something isn't working label Jul 29, 2024
@garethbrickman garethbrickman added the deployment: k8s Related to deploying Dagster to Kubernetes label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment: k8s Related to deploying Dagster to Kubernetes type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants