[2/n] add frontend code link protocol customization in user settings #21467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit d5b89f2. |
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
ebafe76
to
e032f1d
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
eae0aa7
to
882236e
Compare
|
Is there a world where you can configure multiple codelinks and have them all show up in the UI? Maybe in a dropdown. So you could both see the source in DBT cloud for example and in vscode depending on what you're doing. |
salazarm
reviewed
Apr 29, 2024
js_modules/dagster-ui/packages/ui-core/src/code-links/CodeLinkProtocol.tsx
Outdated
Show resolved
Hide resolved
salazarm
approved these changes
Apr 29, 2024
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
e032f1d
to
d0ff45e
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
2 times, most recently
from
943c4c0
to
4216371
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
04406c7
to
859f329
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
4 times, most recently
from
5da8443
to
a39416a
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
0b354bc
to
d46bc1d
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
a39416a
to
e4bb118
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
d46bc1d
to
bda13a9
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
e4bb118
to
4d09dc4
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
bda13a9
to
9fb26a5
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
4d09dc4
to
5134c3f
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
5134c3f
to
5109738
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
0a18e77
to
f7932d1
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
5109738
to
8a65d44
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
f7932d1
to
4afa85d
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
d3a99cc
to
0b67c4a
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
c9a6c28
to
f1abb70
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
0b67c4a
to
860e0ff
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
f1abb70
to
9b5b3cc
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
860e0ff
to
f0c69b4
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
9b5b3cc
to
05695f3
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
2 times, most recently
from
aa8c539
to
00e4fcc
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
8e20595
to
fceb4be
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
00e4fcc
to
092a92e
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
fceb4be
to
33d4e57
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
092a92e
to
1e1f804
Compare
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
33d4e57
to
180d3e7
Compare
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
a8022c9
to
cf04986
Compare
Merge activity
|
benpankow
force-pushed
the
benpankow/add-code-source-metadata-wrapper
branch
from
180d3e7
to
8d6aefa
Compare
Base automatically changed from
benpankow/add-code-source-metadata-wrapper
to
master
May 8, 2024 15:39
benpankow
force-pushed
the
benpankow/add-code-source-option-frontend
branch
from
cf04986
to
d5b89f2
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…agster-io#21467) ## Summary Adds a new user settings option that allows users to specify the protocol to use for links to the editor. Defaults to VSCode but also allows custom protocols to be specified. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new user settings option that allows users to specify the protocol to use for links to the editor. Defaults to VSCode but also allows custom protocols to be specified.