[5/n] frontend for url code references #21713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 3644dc6. |
salazarm
reviewed
May 8, 2024
js_modules/dagster-ui/packages/ui-core/src/metadata/__stories__/MetadataEntry.stories.tsx
Outdated
Show resolved
Hide resolved
salazarm
approved these changes
May 8, 2024
benpankow
force-pushed
the
benpankow/first-pass-source-control-link
branch
from
395cffb
to
df47725
Compare
benpankow
force-pushed
the
benpankow/source-control-link-gql
branch
from
31154d2
to
886e0a6
Compare
salazarm
reviewed
May 9, 2024
js_modules/dagster-ui/packages/ui-core/src/code-links/CodeLink.tsx
Outdated
Show resolved
Hide resolved
benpankow
force-pushed
the
benpankow/first-pass-source-control-link
branch
from
df47725
to
52ed3c8
Compare
benpankow
force-pushed
the
benpankow/source-control-link-gql
branch
from
886e0a6
to
3644dc6
Compare
benpankow
force-pushed
the
benpankow/first-pass-source-control-link
branch
from
52ed3c8
to
70dd254
Compare
benpankow
force-pushed
the
benpankow/source-control-link-gql
branch
from
3644dc6
to
c3d8bde
Compare
Merge activity
|
benpankow
force-pushed
the
benpankow/first-pass-source-control-link
branch
from
70dd254
to
395c0c6
Compare
Base automatically changed from
benpankow/first-pass-source-control-link
to
master
May 15, 2024 21:14
benpankow
force-pushed
the
benpankow/source-control-link-gql
branch
from
c3d8bde
to
1a41d73
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary Adds GQL layer, frontend for source control links. These render with the icon for the corresponding source control service and hyperlink to the targeted URL. <img width="320" alt="Screenshot 2024-05-07 at 5 02 05 PM" src="https://github.com/dagster-io/dagster/assets/10215173/e20956e8-5fc4-479d-b23a-8704eedbc612"> <img width="623" alt="Screenshot 2024-05-07 at 5 02 30 PM" src="https://github.com/dagster-io/dagster/assets/10215173/76408d2f-0956-4279-bd46-fe89b99f493d"> <img width="365" alt="Screenshot 2024-05-07 at 5 06 40 PM" src="https://github.com/dagster-io/dagster/assets/10215173/e09b67cf-4d7e-4950-8644-3134fb746481"> ## Test Plan Tested locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds GQL layer, frontend for source control links. These render with the icon for the corresponding source control service and hyperlink to the targeted URL.
Test Plan
Tested locally.