Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate out __init__ file for metadata pkg #21576

Merged
merged 3 commits into from
May 2, 2024

Conversation

benpankow
Copy link
Member

Summary

Some restructuring/cleanup to make #21465 a bit easier

sryza
sryza previously requested changes May 2, 2024
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise be! Just one comment.

@@ -0,0 +1,957 @@
import os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be named metadata_value.py for more specificity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@benpankow benpankow merged commit ef0341b into master May 2, 2024
1 check passed
@benpankow benpankow deleted the benpankow/restructure-metadata-py branch May 2, 2024 16:00
cmpadden pushed a commit that referenced this pull request May 6, 2024
## Summary

Some restructuring/cleanup to make #21465 a bit easier
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary

Some restructuring/cleanup to make dagster-io#21465 a bit easier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants