Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Issue #2

Closed
tonydero opened this issue Nov 16, 2021 · 4 comments
Closed

Display Issue #2

tonydero opened this issue Nov 16, 2021 · 4 comments

Comments

@tonydero
Copy link

I'm not sure why this is happening as I can't find any errors being thrown, but whenever I run naivecalendar.sh the popup looks as in the image below.

I'm using rofi 1.7.0 and I've tried python 3.6.15, 3.7.11, and 3.9.6. I'm running it directly via the cloned repo. It also happens on every theme I try.

Anywhere I can look to try to debug why it's not displaying properly?

2021-11-16_naivecalendar

@Daguhh
Copy link
Owner

Daguhh commented Nov 17, 2021

Hi, I think it's a rofi issue.
As I can see on the rofi discussions page, the 1.7 rofi version introduce breaking changes in theme configuration.

I'm on debian, and the rofi version here is quite old (1.5.4) and if I remember well, i've tested 1.6 version, but never the 1.7.
I was able to reproduce this on a fresh manjaro intall (rofi 1.7.0-1)

I absolutely don't know if this implies a lot of change in themes, I will dig onto this and try to update them.

Thanks for raising the issue.

@Daguhh
Copy link
Owner

Daguhh commented Nov 17, 2021

ok, a small fix (adding 4 lines in theme config) seems to solve this issue.

I put changes on a new branch

git pull
git switch fix_rofi_1_7_theme_compat 

@tonydero
Copy link
Author

Awesome -- thanks! Looks much better now.

And thanks in general for creating and sharing these.

@Daguhh
Copy link
Owner

Daguhh commented Nov 18, 2021

Great!
Happy you like it and thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants