Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared code in favor of other library #17

Closed
NN--- opened this issue Sep 9, 2018 · 7 comments
Closed

Remove shared code in favor of other library #17

NN--- opened this issue Sep 9, 2018 · 7 comments

Comments

@NN---
Copy link
Contributor

NN--- commented Sep 9, 2018

Instead of implementing basic things like IsFlagSet in Vanara, you could use other libraries which already do this and more, e.g.: https://github.com/rsdn/CodeJam/wiki/M_CodeJam_EnumHelper_IsFlagSet__1

@dahall
Copy link
Owner

dahall commented Sep 9, 2018

I like that EnumHelper (fuller implementation) but I don't need the rest of that library's baggage.

@dahall dahall closed this as completed Sep 9, 2018
@NN---
Copy link
Contributor Author

NN--- commented Sep 18, 2018

I can ask whether this library can be split into smaller parts.
I think your InvokeMethod has also some implementation there.

@dahall
Copy link
Owner

dahall commented Sep 18, 2018

Will you be more specific on both items? I'm not clear on what you're asking.

@NN---
Copy link
Contributor Author

NN--- commented Sep 18, 2018

The purpose of CodeJam library is to have all small extensions that everybody writes in their library.
If most of your extension methods were part of CodeJam, would you use it ?

@dahall
Copy link
Owner

dahall commented Sep 18, 2018

Not yet. It doesn't support .NET 2.0, weakly supports 3.5 and doesn't support .NET Standard 2.0. This library does already.

@NN---
Copy link
Contributor Author

NN--- commented Sep 18, 2018

It does support .NET Standard 2.0 and .NET Core.
.NET 3.5 is supported too, there are some features that cannot be implemented there due to restriction of the framework itself.

As for .NET 2.0, I really doubt that this complication is justified.
This is the main reason why this library doesn't support it.

@NN---
Copy link
Contributor Author

NN--- commented Sep 18, 2018

I'll take a look whether .NET 2.0 can be supported in this library.
Maybe not so hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants