Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Korean Language Dictionary is not included if flag(static) is turned on #1

Closed
dahlia opened this issue Oct 1, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@dahlia
Copy link
Owner

dahlia commented Oct 1, 2019

Standard Korean Language Dictionary (data/ko-kr-stdict.tsv) is not included if flag(static) is turned on. It's because Text.Seonbi.Facade.southKoreanDictionary loads it using Cabal's data-files metadata at runtime, but these data files are not included into the executable binary.

This needs to be fixed so that if flag(static) is turned on at compile-time the code to load the data file uses file-embed instead of Cabal's data-files metadata. Note that file-embed makes data files embedded into the executable binary.

@dahlia dahlia added the bug Something isn't working label Oct 1, 2019
@dahlia dahlia closed this as completed in b76fd5d Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant