Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download section and fix logo in navbar #91

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

larsb24
Copy link
Member

@larsb24 larsb24 commented Aug 2, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 10:22pm

- rework download section
- simplify StyledButton into one file
- remove menu from Toolbar
- add community banner
- update background image
- change all icons to rounded
- update donation page
- add new stuff to tsconfig
<>
<Card>
<h1>Join the Community!</h1>
<div style={{ height: "3rem" }} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not super important for this component, but probably should still do for the sake of consistency:

inline styles should be a no-no, not only does it recreate a new object everytime its rendered its just slightly ugly.

<DownloadTitle>{oldRelease.name}</DownloadTitle>
</StyledLink>
<DownloadSubtitle>
{getDate(oldRelease.published_at)} ꞏ{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


what is this haha

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in /components + should be capitalized (e.g Button.tsx)

@@ -8,9 +8,10 @@ import { ThemeProvider as MUIThemeProvider } from "@mui/material";
import { SWRConfig } from "swr";
import { usePreferredTheme } from "../utils/hooks/usePreferredTheme";
import { Inter } from "@next/font/google";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn remove @next/font

Suggested change
import { Inter } from "@next/font/google";
import { Inter } from "next/font/google";

@@ -79,9 +80,7 @@ $$ $$ |$$ $$ |$$ | $$ |$$ |$$ |$$ $$ |$$ $$/ $$ $$/

return (
<>
<Head>
<meta name="viewport" content="width=device-width" />
</Head>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should actually be in the <Head> tag in _document.tsx, not sure why its not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it actually complains when it's in _document which is why i placed it inside _app

"@mui/icons-material": "^5.14.3",
"@mui/material": "^5.14.3",
"@mui/styles": "^5.14.3",
"@next/font": "^13.4.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm remove @next/font

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants