do not printf errors on stdout, please use fprintf(stderr,...) instead

[devZer0]

libsml prints errors on stdout and not on stderr.

please consider using fprintf(stderr,"error.....\n",value); instead

2 reasons for that:

1st:
root@wheezy:~/libsml# while true;do cat /dev/ttyUSB0 |./sml_server_stdio ;done
error: unknown type in sml_value_to_double
error: unknown type in sml_value_to_double
14797050.70 Wh
2012.40 Wh
error: unknown type in sml_value_to_double
20.70 W
^C

root@wheezy:~/libsml# while true;do cat /dev/ttyUSB0 |./sml_server_stdio ;done 2>/dev/null
14797050.80 Wh
2012.40 Wh
21.10 W
^C

2nd:
People re-implement sml_value_to_double() within their code - see: http://knx-user-forum.de/201949-post60.html

regards
roland

root@wheezy:~/libsml/libsml/sml/src# grep print * |egrep "warning|error"
sml_file.c: printf("warning: could not read the whole file\n");
sml_message.c: printf("error: message type %04X not yet implemented\n", *(msg_body->tag));
sml_message.c: printf("error: message type %04X not yet implemented\n", *(message_body->tag));
sml_transport.c: printf("error: unrecognized sequence\n");
sml_tree.c: printf("error: unknown tag in %s\n", FUNCTION);
sml_value.c: printf("error: unknown type in %s\n", FUNCTION);

[devZer0]

oh, and please consider using fprintf(stderr,"libsml error.....\n",value) or similar, so it`s more clear that the error is from libsml and not from the program implementing it

[r00t-]

more correctly, a library should ideally not print errors itself at all,
but report them to the caller.
(for example through a configurable error logging callback.)

[hmueller01]

@devZer0 I think you can close this with reference to volkszaehler.

[devZer0]

yes, i also just added this one: #14