feat: move to react from preact #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: remove preact * feat: remove alias configurations
feat: pass getContentScriptPermission instead of the hook which would trigger invalid hook call feat: move origin as parameter for requestContentScripts to avoid requiring origin on places where requestContentScripts is not used feat: move useContentScriptStatus to shared
it was used for preact only
We used a dynamic render, but should have use our conditional render instead since it would simply render a empty fragment. WT-1837 #done
Fixed useRef case, we manually defaulted to null and for this component it often doesn't get passed. So using the "default" null is actually better and more stable. WT-1849 #done
Add index key to tooltip on calendar heatmap render WT-1854 #done
* fix: notifications page build * fix: portal unable to append to document * refactor: seo needed outside
* refactor: nested anchor tags * fix: optional prop
- the toast is triggered optimistically upon submission, so waiting for the mutation to finish executing might generate situations where the toast is already gone and the assertion would fail. ref WT-1834
* fix: notification card z-index * fix: avatar * fix: build
rebelchris
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Describe what this PR does
Events
Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet
Log the new/changed events below:
Please make sure existing components are not breaking/affected by this PR
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
WT-{number} #done