Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages detected in input document should be mentioned in scripts that use TTS #226

Open
prashantverma2014 opened this issue May 21, 2024 · 6 comments
Labels
engine Issues that require something to change on the engine side

Comments

@prashantverma2014
Copy link
Collaborator

In scripts such as DTBook to DAISY 3, after the DTBook browse field, there can be a read only text box that displays languages/dialects detected in the input file selected by the user.
Some text like "Make sure you select TTS voices for these languages" can be added over there.

@bertfrees
Copy link
Member

While I agree it could be useful information for the user to have, I'm not sure that the warning would not confuse people, at least the way it is worded right now, because Pipeline is capable of selecting the right voice for the right languages (if the TTS engines have been set up correctly). What of course is left up to the user is to set voice preferences. But that is not required to get a "correct" output.

Perhaps the user should only get a warning when the app detects a potential issue in the settings, e.g. if there are multiple alternatives for a language that occurs in the document, and the user hasn't set up any preferences in the GUI or CSS, so that the output would be undetermined.

@prashantverma2014
Copy link
Collaborator Author

prashantverma2014 commented May 22, 2024 via email

@bertfrees
Copy link
Member

I'm in favor of the extra information. We can think about whether
warnings could also be useful, and how to word them.

@bertfrees
Copy link
Member

I have an idea for a new API call for providing this kind of information. It will be something for a future version.

@bertfrees bertfrees added the engine Issues that require something to change on the engine side label Jun 1, 2024
@marisademeglio marisademeglio added this to the 1.6 milestone Jun 17, 2024
@bertfrees
Copy link
Member

See daisy/pipeline-modules#96

@marisademeglio
Copy link
Member

Re stylesheet-parameters and voices endpoints
https://daisy-dev.slack.com/archives/C064GB8U9/p1724083351219419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues that require something to change on the engine side
Projects
Status: Cancelled
Development

No branches or pull requests

3 participants