Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS specific tray icon #111

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add macOS specific tray icon #111

merged 1 commit into from
Mar 7, 2023

Conversation

bertfrees
Copy link
Member

@bertfrees bertfrees commented Mar 7, 2023

It's a slightly simplified and monochromatic version of the known Pipeline logo. The image file is named according to the standard that Electron expects, so that macOS magically inverts the image (white on blue instead of black on white) when clicked, and so that the dimensions are right.

I've only included a high density (@2x) image and tested this only on my Macbook with retina display. I fear that it might not work with a normal display.

The resolution of the image is 40x40. The recommended size is 32x32, but I've made it a little bigger so that dimensions of the globe are closer to 32x32 and the pipes stick out a little. This makes it fit better with icons of other apps.

I recreated the original logo with SVG and converted to PNG using GIMP.

Electron documentation: https://www.electronjs.org/docs/latest/api/tray

@bertfrees bertfrees mentioned this pull request Mar 7, 2023
@marisademeglio
Copy link
Member

I just tested this PR and I think it looks fine on my external LG display as well as my macbook retina.

from the external display:
Screenshot 2023-03-07 at 10 10 47

@marisademeglio marisademeglio merged commit c095494 into main Mar 7, 2023
@bertfrees bertfrees deleted the tray-icon branch March 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants