Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray icon size #103

Open
bertfrees opened this issue Mar 6, 2023 · 7 comments
Open

Tray icon size #103

bertfrees opened this issue Mar 6, 2023 · 7 comments

Comments

@bertfrees
Copy link
Member

bertfrees commented Mar 6, 2023

On macOS, the tray icon is two times too large on retina displays.

Some time ago I made a patch that addressed this problem. I need to have a look at it and see if I can make a PR from it. That patch also includes a nicer designed tray icon. It is derived from the known Pipeline icon, but slightly more simplistic. It is also monochromatic like tray icon ought to be on Mac, and the black and white is inverted when clicked. Note that this doesn't change anything for Windows.

@bertfrees
Copy link
Member Author

bertfrees commented Mar 6, 2023

Does it look like it is supposed to look on Windows?

@ways2read
Copy link
Member

Screenshot 2023-03-06 173105
Screenshot of my Windows 11 system tray is attached (hopefully).

@ways2read
Copy link
Member

Screenshot 2023-03-06 at 17 39 39
Screenshot from my Mac desktop (not a Retina display) but it shows colored icon whereas most of the others are monochrome.

@bertfrees
Copy link
Member Author

Thanks for the screenshots. OK so it is also too big for you on Mac, while on Windows it looks a little small compared to other icons (the pipes could stick out a bit from the recommended area). I'll create a PR for the Mac part.

@bertfrees
Copy link
Member Author

See #111.

@marisademeglio
Copy link
Member

See #111.

tested and merged. So this is now just a Windows issue.

@marisademeglio marisademeglio changed the title Tray icon too large on retina displays Tray icon size Mar 8, 2023
@NPavie
Copy link
Collaborator

NPavie commented Mar 15, 2023

For the windows icon, the problem is that the icon rendering size is fixed by windows.
Even if I put a bigger icon, it will still be rendered the same in the tray (in terms of size).

The issue with the icon here is that it has a large part of it transparent, especially on borders due to the "pipes" in the icon

To have a visually more visible icon, we might need to make a more "cropped" version of it (with shorter pipes for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants