Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View no longer updating after CefBrowserHost::WasResized #3

Closed
blattersturm opened this issue Mar 6, 2018 · 4 comments
Closed

View no longer updating after CefBrowserHost::WasResized #3

blattersturm opened this issue Mar 6, 2018 · 4 comments

Comments

@blattersturm
Copy link

To support changing video modes dynamically, our application uses WasResized to resize the existing browser view upon detection of a mode change.

However, with this patch set, usage of WasResized (and returning a different resolution in GetViewRect) will stop updating the browser view after resizing it. (OnAcceleratedPaint no longer being called, initial debugging inside Chromium shows that no BeginFrame calls are being generated anymore)

@mihe
Copy link
Contributor

mihe commented Mar 6, 2018

Just to chime in I can say that we don't experience this issue. For us calling CefBrowserHost::WasResized triggers (at some later point) a call to OnAcceleratedPaint with a new shared_handle. Much like the example application we then check whether the new one matches our cached one and recreate the texture (with the new size) if it doesn't.

@blattersturm
Copy link
Author

That's weird - what flags are you using in your CefApp::OnBeforeCommandLineProcessing? It might also be something else we're doing is conflicting with this... 😕

@mihe
Copy link
Contributor

mihe commented Mar 6, 2018

disable-gpu-vsync is the only one we're using at the moment. It shows the same behavior regardless if I include that one or not though.

@blattersturm
Copy link
Author

Ah, thanks! We had in-process-gpu in there due to a prior accelerated rendering patch, which seems to conflict with disable-gpu-vsync being used at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants