Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect DOCKER_HOST for reading docker info #423

Closed
WhyNotHugo opened this issue Jan 26, 2023 · 3 comments · Fixed by #424
Closed

Respect DOCKER_HOST for reading docker info #423

WhyNotHugo opened this issue Jan 26, 2023 · 3 comments · Fixed by #424

Comments

@WhyNotHugo
Copy link
Contributor

unix:///var/run/docker.sock is the default path, but only used when running docker as root. When running docker as non-root the environment variable DOCKER_HOST defines the socket of the docker path.
@WhyNotHugo
Copy link
Contributor Author

Maybe changing ConfigDocker::default() would make sense here?

@WhyNotHugo
Copy link
Contributor Author

I can submit a patch if that seems like a reasonable approach.

@dalance
Copy link
Owner

dalance commented Jan 27, 2023

I think it seems to be good.

@WhyNotHugo WhyNotHugo mentioned this issue Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docker: Respect $DOCKER_HOST
2 participants
@WhyNotHugo @dalance