curve: Fix no_std for fiat backend and add test for it
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkforest
force-pushed
the
add-fiat-no_std
branch
from
bd1ff6c
to
057c3f6
Compare
pinkforest
force-pushed
the
add-fiat-no_std
branch
from
057c3f6
to
cd6536f
Compare
pinkforest
force-pushed
the
add-fiat-no_std
branch
from
cd6536f
to
8e1447c
Compare
pinkforest
changed the title
no_std test for fiat backendno_std for fiat backend and add test for it
|
Suddenly I'm confused why there's both a |
|
Yeah Maybe we can rename the Or just merge I thought fiat no_std needs to be only tested when curve25519-dalek has changes - serial gets tested always in any case Do we want to test both |
pinkforest
force-pushed
the
add-fiat-no_std
branch
from
fd94065
to
e75ef04
Compare
tarcieri
approved these changes
Sep 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiat backend required std as we didn't call it with
default-features - false- I've changed it here.We only test the serial (default) backend in
no_stdthat gets tested changes on any cratesThis adds fiat backend specific no_std test when there is/are changes on curve25519-dalek in addition.
Given mit-plv/fiat-crypto#1646 it may be feasible to fiat is tested as well
This should be merged and re-based into the fiat-backend 0.2 bump after this has been tested with 0.1 via this PR