Adapt to new types introduced in fiat-crypto 0.2 #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
force-pushed
the
fiat-crypto-newtype
branch
2 times, most recently
from
d60c18b
to
e4a90b3
Compare
|
The new fiat-crypto version is out, so this is ready now. |
pinkforest
reviewed
Sep 4, 2023
|
Thanks 🎉 - I'm benching this atm for any regressions - I noted there was |
|
@divergentdave can you rebase now that #572 has been merged? |
divergentdave
force-pushed
the
fiat-crypto-newtype
branch
from
e4a90b3
to
e28b22e
Compare
tarcieri
approved these changes
Sep 4, 2023
|
🎉 |
Merged
|
Merging so we can get this in #574 |
pinkforest
pushed a commit
to pinkforest/curve25519-dalek
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an outstanding PR that proposes some breaking changes to fiat-crypto, see mit-plv/fiat-crypto#1623. Briefly, it introduces new structures to replace different type aliases for each field element representation. Encoding this in the type system is intended to prevent misuse of functions that require "tight" preconditions on their inputs' ranges. I'm opening this PR for a future crate upgrade early, with a
[patch.crates-io]stanza, to test out the breaking change, and for temporary use in fiat-crypto's integration tests. If this looks good, I can back out the patch stanza whenfiat-cryptois released and mark it ready for review.