-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switch to a timer-based approach for Firefox handling (#960)
After switching the logger to a less verbose option, it turns out that the `FirefoxWindowProcessor` wouldn't work reliably. I think two things were occurring here: 1. No `EVENT_OBJECT_CLOAKED` event was being sent sometimes, causing Whim to ignore events to the Firefox window. 2. The Firefox window wouldn't respect Whim's `SetWindowPos` calls due to Firefox's window startup logic. The following changes have been made, respectively: 1. The `FirefoxWindowProcessor` now listens to all events after a timeout of 5 seconds. This is unpleasant, but seems necessary to handle the case when `EVENT_OBJECT_CLOAKED` was not emitted. 2. Ignored events can now trigger layouts. This necessitated a change to the `WindowProcessorManager`.
- Loading branch information
Showing
5 changed files
with
51 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters