Switch to a timer-based approach for Firefox handling #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After switching the logger to a less verbose option, it turns out that the
FirefoxWindowProcessor
wouldn't work reliably. I think two things were occurring here:EVENT_OBJECT_CLOAKED
event was being sent sometimes, causing Whim to ignore events to the Firefox window.SetWindowPos
calls due to Firefox's window startup logic.The following changes have been made, respectively:
FirefoxWindowProcessor
now listens to all events after a timeout of 5 seconds. This is unpleasant, but seems necessary to handle the case whenEVENT_OBJECT_CLOAKED
was not emitted.WindowProcessorManager
.