Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: use @cached_property #26

Closed
glyg opened this issue Jun 3, 2016 · 2 comments
Closed

ENH: use @cached_property #26

glyg opened this issue Jun 3, 2016 · 2 comments
Milestone

Comments

@glyg
Copy link
Member

glyg commented Jun 3, 2016

Where necessary, i.e for topology dependant indexing elements

https://pypi.python.org/pypi/cached-property

then complete reset_topo by flushing (del the property in self.__dict__ like indicated in the examples)

@glyg glyg added this to the 0.2 milestone Oct 25, 2016
@glyg glyg modified the milestones: 0.2, 0.3 Jan 29, 2018
@glyg
Copy link
Member Author

glyg commented Jan 29, 2018

This is deferred to a new optimization campaign

@glyg
Copy link
Member Author

glyg commented Dec 4, 2018

latest optimization shows, imho, that this might not be a good way to optimize. In order to avoid repeated calls to upcast, storing the values directly in edge_df seems a better and easier practice. Closing

@glyg glyg closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant