Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colours for report #383

Closed
rommy1204 opened this issue Mar 29, 2016 · 11 comments
Closed

Update colours for report #383

rommy1204 opened this issue Mar 29, 2016 · 11 comments

Comments

@rommy1204
Copy link

Hi Damian,

Is it possible to make colours in the report not so bright?
Our eyes are getting tired so much while working with current colours
Now it is:
now
With previous colours (as it was in earlier version):
was
It could be another colours, just not so saturated :)
for the second screenshot I used:

.passed {
background-color: #C5D88A;
}

.failed {
background-color: #D88A8A;
}

@tommywo
Copy link
Contributor

tommywo commented Mar 29, 2016

+1

1 similar comment
@Seploid
Copy link

Seploid commented Mar 29, 2016

+1

@damianszczepanik
Copy link
Owner

I wanted to have the same colors for reports and charts. I can update them if you provide examples which are not so poor and unhappy as previous :)

@rommy1204
Copy link
Author

Damian, how about these colours? Something between previous and current
prososal1

@Ploskodonka
Copy link

Thats how it looks now with chart
2016-03-29_1601
I used the following colors:

.passed {
    background-color: #92DD96;
}

.failed {
    background-color: #F2928C;
}

.skipped {
    background-color: #8AF;
}

.pending {
    background-color: #F5F28F;
}

.undefined {
    background-color: #F5B975;
}

.missing {
    background-color: #FAB3E9;
}

@rommy1204
Copy link
Author

Damian, as I noticed, we can also change colours for highcharts here
https://github.com/damianszczepanik/cucumber-reporting/blob/master/src/main/resources/templates/pages/featuresOverview.vm
And we can make them the same as for the report
@Ploskodonka , I like your colours :)

@damianszczepanik
Copy link
Owner

Prepare PR with updated colors for report but keep chars unchanged. Does it make sense?

@nbarrett
Copy link

nbarrett commented May 4, 2016

Hi @damianszczepanik - I'm a little unsure about what's happening now with this colour change? I agree with @rommy1204 about making them more gentle on the eyes and I also agree with allowing errors to be displayable without needing to scroll them as version 2.1.0 seems to be causing unrest in the community! Thanks for the best BDD plugin on the planet! @nbarrett

@damianszczepanik
Copy link
Owner

This plugin works as Agile - if you think something is wrong/ugly/etc you can send PR and improve it. Thus the UX may change from time to time if someone decides that the current approach is not perfect and can prove, that better solution can be implemented :)

@nbarrett
Copy link

nbarrett commented May 4, 2016

Cool - I understand agile - was just trying to understand whether any work was underway (from anyone) to implement requests in the various threads.. Looks like you are waiting for PR following comment on 29th Mar yes?

@damianszczepanik
Copy link
Owner

I don't wait since this issue is closed but any other contributions are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants