Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically broadcast quote notes (quoted re-posts) #1495

Closed
alltheseas opened this issue Aug 21, 2023 · 2 comments
Closed

Automatically broadcast quote notes (quoted re-posts) #1495

alltheseas opened this issue Aug 21, 2023 · 2 comments
Assignees
@danieldaquino
Labels
enhancement Improvement good-first-issue Good for newcomers

Comments

@alltheseas
Copy link
Collaborator

alltheseas commented Aug 21, 2023 •
edited
Loading

user story

As a Damus user who is quoting a note, I would like Damus to automatically broadcast said note upon quote-note, so that my quote note can reach my followers, and other nostr network nostriches.

acceptance criteria

  1. if pleb quote notes a note (quote re-post), Damus automatically broadcasts said quote note

comment
Damus already does this when replying (may be issue for private relays; future problem)
@alltheseas alltheseas added enhancement Improvement good-first-issue Good for newcomers labels Aug 21, 2023
@alltheseas alltheseas changed the title Broadcast quote notes (quoted re-posts) Automatically broadcast quote notes (quoted re-posts) Aug 21, 2023
@danieldaquino
Copy link
Contributor

Starting to work on this one!

@danieldaquino
Copy link
Contributor

Patch

Sent a patch via email that fixes this issue. All code, testing documentation, and discussion can be visualized here: https://groups.google.com/a/damus.io/g/patches/c/yGDKOaqpSpg

@jb55 jb55 closed this as completed in a06be64 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieldaquino danieldaquino

Labels
enhancement Improvement good-first-issue Good for newcomers
Projects
Damus Roadmap 🛣️
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieldaquino @alltheseas