-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Damus Mutiny NWC #1954
Comments
Doing some testing and mutiny never gets the request, this is how we construct our filter. The timestamp is the timestamp of the last event we processed https://github.com/MutinyWallet/mutiny-node/blob/master/mutiny-core/src/nostr/nwc.rs#L269 |
damus works with many NWC implementations, why do we have to make an exception for mutiny? I'm confused. |
same with mutiny, just want to figure out why damus <> mutiny doesn't work when damus seems to work with everything else and mutiny seems to work with everything else |
Received a NWC failure report. Tracking down which wallet |
On Mon, Feb 05, 2024 at 07:12:04AM -0800, alltheseas wrote:
Received a NWC failure report. Tracking down which wallet
https://damus.io/nevent1qqsw8ckv64n0ax3a82a6crrrfn47856y7trlevs7e5jw2f4gz98ducqpzfmhxue69uhk7enxvd5xz6tw9ec82cspr4mhxue69uhkummnw3ez6ur4vgh8wetvd3hhyer9wghxuet5qydhwumn8ghj7mn0wd68ytfj9eax2cn9v3jk2tnrd3hh2eqpzamhxue69uhkv6tvw3jhytnwdaehgu3wwa5kueg7e93pa
This is probably someone just trying to scan a lightning invoice
thinking this will somehow attach the wallet, this seems to be a very
common problem.
maybe we need to hide this under advanced or something.
|
Confirmed this one was a newbie trying to set up a wallet that does not support NWC (strike). Maybe a list of compatible wallets fixes this #1976 |
i found the issue here I can get it to work with the NWC URI:
but mutiny/rust-nostr produces them like
the difference being that the relay url is uri encoded the spec does have the url as uri encoded so I would say this is a damus bug https://github.com/nostr-protocol/nips/blob/master/47.md#example-connection-string Maybe a good sanity check would be to have it try to connect to the relay when configuring NWC |
|
Hah, I thought I was just doing it wrong. This might fix the issue: #2037 |
RelayPool caches connections to relays. Since you don't want This might actually be causing a lot of issues beyond NWC |
@benthecarman 's example isn't what it seems. The encoded parameter isn't confusing Damus, it's confusing us:
Notice the |
So is this fixed or a PR fixing it? I see the problem is tracked down but no reference PR and the issue is still opened. |
Daniel's patch does what Will was asking for, as discussed in #2072 |
Thanks @ericholguin. Did not notice the nwc test cases @danieldaquino ran on the relay slash issue. If this pr fixes nwc 🔥 |
@danieldaquino advised we might have to do more in depth testing to confirm that the relay slash issue fix, also fixes Mutiny NWC |
Adding as bonus points to sprint 12, as this is related to the recently fixed relay slash / cannot remove relay issue, and affects user experience negatively @danieldaquino @jb55 |
Our latest release no longer has the trailing slash |
Can confirm this is fixed in both existing apple store version and upcoming release |
Really? People say it's not working |
Looks like Damus needs to be restarted for the relay connection to go through. Not sure why. |
@ericholguin advised that there is something bigger than Mutiny outstanding - Alby also affected |
How might we communicate NWC relay is different than a note relay? |
Problem confirmed as originating from Damus by @benthecarman
nostrability/nostrability#13
The text was updated successfully, but these errors were encountered: