Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build instructions to Readme #290

Closed
wants to merge 2 commits into from
Closed

Add build instructions to Readme #290

wants to merge 2 commits into from

Conversation

JakobDev
Copy link
Contributor

@SquidDev
Copy link
Contributor

SquidDev commented May 29, 2017 •
edited
Loading

You don't technically need step 3, it just makes development a little easier. If people just want to use the latest version then ./deploy.sh is sufficient. Seeing as it takes 5-10 minutes to run on my machine, it might be worth mentioning this.

Of course, if #186 or #163 are merged then we don't need the ./deploy.sh step either 😛.

dan200
dan200 reviewed Jun 28, 2017
View reviewed changes
README.md

1. `git clone` this repository onto your machine.
2. `cd` to it.
3. Run `./deploy.sh` on Unix, or `gradlew.bat build` on Windows.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't good advice, as gradlew.bat build does not do the same things as deploy.sh yet

dan200
dan200 reviewed Jun 28, 2017
View reviewed changes
README.md

To build ComputerCraft, follow these steps:

1. `git clone` this repository onto your machine.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to tell the user how to checkout the repository

dan200
dan200 reviewed Jun 28, 2017
View reviewed changes
README.md
To build ComputerCraft, follow these steps:

1. `git clone` this repository onto your machine.
2. `cd` to it.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to tell the user how to change directory

@SquidDev SquidDev mentioned this pull request Jan 25, 2018
Closed
@JakobDev JakobDev closed this by deleting the head repository Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan200 dan200 dan200 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakobDev @SquidDev @dan200