New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create setup.md #510

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@JasonTheKitten

JasonTheKitten commented Jan 25, 2018

This is so that people know how to set it up

Run each of those, and wait for them to install.
Next, open git bash and run the following:
git clone you will need to download the following files:

This comment has been minimized.

@lupus590

lupus590 Jan 25, 2018

Contributor

i think you have a copy paste error or something here

This comment has been minimized.

@JasonTheKitten

JasonTheKitten Jan 26, 2018

Yea I did have a copy/paste error. A few, in fact

@SquidDev

This comment has been minimized.

Contributor

SquidDev commented Jan 25, 2018

I'm going to be honest, I do feel this is overly complicated for what equates to:

  • Clone the repo
  • Run ./gradlew setupDecompWorkspace in the directory
  • Import build.gradle into your editor of choice.

Have a look at some of Dan's comments on #290 as well - one doesn't need to spoon feed it to the user.

@SquidDev

This comment has been minimized.

Contributor

SquidDev commented Jan 26, 2018

@JasonTheKitten You want to make things easier, and I can respect that. The issue is that once you've used Gradle once, it's the same elsewhere. I don't think we need to serve as an introduction to Gradle, just provide a couple of simple steps and link to something like this should people more information.

With respect to CC specific build steps, we should probably mention deploy.sh, at least until we remove the need for it.

@lupus590

This comment has been minimized.

Contributor

lupus590 commented Jan 26, 2018

With respect to CC specific build steps, we should probably mention deploy.sh, at least until we remove the need for it.

And to save pain later say something like this. "If there is no deploy.sh then it may be because CC doesn't need it anymore."

@JasonTheKitten

This comment has been minimized.

JasonTheKitten commented Jan 26, 2018

I use windows cmd not linux bash so I can't use sh files
EDIT: (Unless git supports them? But that would be like forcing windows to use the linux package manager and paths and file structure and all that stuff)

@JasonTheKitten

This comment has been minimized.

JasonTheKitten commented Jan 26, 2018

once you've used Gradle once, it's the same elsewhere.

What does that mean? If you mean it makes new gradle files, then can't we just use copy/paste instead of the git command? Or delete the new folders?

@SquidDev

This comment has been minimized.

Contributor

SquidDev commented Jan 26, 2018

once you've used Gradle once, it's the same elsewhere.

What does that mean?

Once you've set up Gradle in your editor once, it's pretty much the same procedure in any other project which uses Gradle.

@lupus590

This comment has been minimized.

Contributor

lupus590 commented Feb 1, 2018

@JasonTheKitten are you aware that you still have this pull request open and you have made a commit against it which seems irrelevant to the pull request?

@SquidDev

This comment has been minimized.

SquidDev commented on 3c908f1 Feb 1, 2018

You probably want to do this on a separate branch, otherwise it'll be bundled with dan200#510

@JasonTheKitten

This comment has been minimized.

JasonTheKitten commented Feb 1, 2018

That was an accident
I meant to put it in my master-http branch

I don't really expect this to be merged though.

Also, is their a way to change/undo files/commits without it incrementting the commit counter?

@lupus590

This comment has been minimized.

Contributor

lupus590 commented Feb 1, 2018

https://sethrobertson.github.io/GitFixUm/fixup.html

You will need to force the push, after following the steps in the above link, do this with git push -f (assuming you have your default remote set correctly)

Also, check which branch you are committing to before you start editing things.

@dmarcuse

This comment has been minimized.

Contributor

dmarcuse commented Feb 1, 2018

Force pushing is a bad idea. If you've already pushed erroneous commits (which you have) you should just revert the changes instead.

When merging the commits can be squashed or cherry picked if dan is worried about extra commits.

@KnightMiner

This comment has been minimized.

KnightMiner commented Feb 1, 2018

Reverting leaves a revert commit which makes the PR much harder to review. Force push is perfectly valid for PRs

@dmarcuse

This comment has been minimized.

Contributor

dmarcuse commented Feb 1, 2018

The files changed tab (usually used for reviews) will not show the difference because the changes are reverted, and the extra commits can be dropped when merging.

@thatcraniumguy

This comment has been minimized.

thatcraniumguy commented May 23, 2018

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment