Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Add Retry Mechanism for Certify Requests #3

Open
arielsepton opened this issue May 27, 2024 · 0 comments
Open

Add Retry Mechanism for Certify Requests #3

arielsepton opened this issue May 27, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@arielsepton
Copy link
Contributor

Description:

Currently, the operator sends requests to the Certify service to obtain certificates. However, there are scenarios where the request might fail temporarily due to network issues or service unavailability. To improve the reliability of the operator, we propose adding a retry mechanism for Certify requests.

Proposed Solution:

Introduce a new configuration option in CertificateConfig called rollbackRetriesLimit of type boolean.
When rollbackRetriesLimit is set to true, the operator will automatically retry failed Certify requests until a successful status code is returned.
If rollbackRetriesLimit is set to false, the operator will not perform retries and will return an error immediately upon a failed request.

How to test

  • Use the existing CertificateConfig resource provided in the sample configuration.

  • Check Requests Sent to Beeceptor:
    Visit the Beeceptor console to monitor incoming requests.
    Verify that requests from the certificate-operator reach the Beeceptor endpoint.
    Ensure that the requests contain the expected data and parameters.

@arielsepton arielsepton added the good first issue Good for newcomers label May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant