Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link_settings does not work for targets of type none #39

Closed
GoogleCodeExporter opened this issue Sep 9, 2015 · 2 comments
Closed

link_settings does not work for targets of type none #39

GoogleCodeExporter opened this issue Sep 9, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Have a target of type none
2. Attempt to place a link_settings section inside of it

Take a look at ffmpeg.gyp:
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/ffmpeg/ffmpeg.gyp
?revision=19579&view=markup

The settings do not get propagated to executables and shared libraries.  The 
current workaround is to place it inside of a direct_dependent_settings 
section, which will make the media lib pick up the link_settings, where it 
will then propagate to executables and shared libraries.

Original issue reported on code.google.com by scherkus@chromium.org on 30 Jun 2009 at 10:53

@GoogleCodeExporter
Copy link
Author

Slight redefinition of the input.py semantics for handling 'none'.

Original comment by sgk@chromium.org on 6 Aug 2009 at 6:29

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

I believe direct_dependent_settings is considered the Correct way to do this.

Original comment by evan@chromium.org on 14 Sep 2011 at 9:14

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant