Skip to content

Commit

Permalink
build,win: include addons-napi in linter
Browse files Browse the repository at this point in the history
Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.

PR-URL: nodejs#16181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
danbev committed Oct 16, 2017
1 parent 8942581 commit 7832e69
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ goto lint-cpp

:lint-cpp
if not defined lint_cpp goto lint-js
call :run-lint-cpp src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h
call :run-lint-cpp src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\addons-napi\*.cc test\addons-napi\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h
call :run-python tools/check-imports.py
goto lint-js

Expand Down Expand Up @@ -502,6 +502,9 @@ if %errorlevel% equ 0 goto exit
echo %1 | findstr /r /c:"test\\addons\\[0-9].*_.*\.cc"
if %errorlevel% equ 0 goto exit

echo %1 | findstr /c:"test\\addons-napi\\common.h"
if %errorlevel% equ 0 goto exit

set "localcppfilelist=%localcppfilelist% %1"
goto exit

Expand Down

0 comments on commit 7832e69

Please sign in to comment.